Add h2 anchors where missing #1070
Open
+55
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobucchi
requested review from
timsneath,
tkremenek,
shahmishal,
davelester,
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub and
kaishin
as code owners
kaishin
approved these changes
Jun 7, 2025
|
@federicobucchi can you resolve the conflicts? |
federicobucchi
force-pushed
the
fb/more-h2-anchors
branch
from
7c185d6 to
053aa13
Compare
|
@shahmishal done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have
## titlethat are automatically creating anchors for deep links.Some are not because they are in HTML files.
Modifications:
Added script to get the
h2with a specific class to have the anchorResult:
Added class for
h2I thought should be with anchor (not all).We can do also for others later on, if we think are helpful.
We can also think to do it for some
h3.